Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace column comparison utilities functions with macros #11007

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Replace column comparison utilities functions with macros #11007

merged 1 commit into from
Jun 1, 2022

Conversation

karthikeyann
Copy link
Contributor

Replaced macros provide the line of failure in the test code file which the functions can not provide.

@karthikeyann
replace column comparison utilities functions with macros
333bb7f 
replaced macros provide the line of failure in the test code file which
the functions can not provide.
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 31, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 31, 2022 02:39
@karthikeyann karthikeyann requested review from PointKernel and a team June 1, 2022 08:51
PointKernel
PointKernel approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5367858 into rapidsai:branch-22.08 Jun 1, 2022
@PointKernel PointKernel mentioned this pull request Nov 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @ttnghia @PointKernel