Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace column comparison utilities functions with macros #11007

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Replace column comparison utilities functions with macros #11007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cpp/docs/TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,12 +411,12 @@ auto struct_col {struct_column_wrapper.release()};
A common operation in testing is verifying that two columns are equal, or equivalent, or that they
have the same metadata.

#### `expect_column_properties_equal`
#### `CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUAL`

Verifies that two columns have the same type, size, and nullability. For nested types, recursively
verifies the equality of type, size and nullability of all nested children.

#### `expect_column_properties_equivalent`
#### `CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUIVALENT`

Verifies that two columns have equivalent type and equal size, ignoring nullability. For nested
types, recursively verifies the equivalence of type, and equality of size of all nested children,
Expand All @@ -428,17 +428,17 @@ different scales. Nested type columns can be equivalent in the case where they b
but one has children (also empty) and the other does not. For columns with nonzero size, both equals
and equivalent expect equal number of children.

#### `expect_columns_equal`
#### `CUDF_TEST_EXPECT_COLUMNS_EQUAL`

Verifies that two columns have equal properties and verifies elementwise equality of the column
data. Null elements are treated as equal.

#### `expect_columns_equivalent`
#### `CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT`

Verifies that two columns have equivalent properties and verifies elementwise equivalence of the
column data. Null elements are treated as equivalent.

#### `expect_equal_buffers`
#### `CUDF_TEST_EXPECT_EQUAL_BUFFERS`

Verifies the bitwise equality of two device memory buffers.

Expand Down