Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groupby include #11046

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Fix groupby include #11046

merged 1 commit into from
Jun 3, 2022

Conversation

bwyogatama
Copy link
Contributor

This PR fixes include that are not grouped correctly in groupby.hpp.
This is my first pull request that I'm working on with @bdice !

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 3, 2022
@bdice bdice added tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 3, 2022
@bwyogatama bwyogatama marked this pull request as ready for review June 3, 2022 21:36
@bwyogatama bwyogatama requested a review from a team as a code owner June 3, 2022 21:36
@bwyogatama bwyogatama requested review from mythrocks and ttnghia June 3, 2022 21:36
bdice
bdice approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this fix. :)

PointKernel
PointKernel approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@fe9a4f8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11046   +/-   ##
===============================================
  Coverage                ?   86.33%           
===============================================
  Files                   ?      144           
  Lines                   ?    22706           
  Branches                ?        0           
===============================================
  Hits                    ?    19604           
  Misses                  ?     3102           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9a4f8...a828bf7. Read the comment docs.

@bwyogatama
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@ttnghia
Copy link
Contributor

ttnghia commented Jun 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 936a32a into rapidsai:branch-22.08 Jun 3, 2022
@ttnghia
Copy link
Contributor

ttnghia commented Jun 3, 2022

@gpucibot merge

So you may need to be added to the writer group 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bwyogatama bwyogatama

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwyogatama @ttnghia @bdice @PointKernel