Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Include skbuild directory into build.sh clean operation #11060

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR includes deletion of _skbuild build artifacts in clean option of build.sh

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2022
@galipremsagar galipremsagar requested a review from vyasr June 6, 2022 20:29
@galipremsagar galipremsagar self-assigned this Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@10c4c33). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11060   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22723           
  Branches                ?        0           
===============================================
  Hits                    ?    19620           
  Misses                  ?     3103           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4c33...10091d0. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented Jun 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ec93336 into rapidsai:branch-22.08 Jun 7, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants