Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix duplicate cudatoolkit pinning issue #11070

Merged
merged 7 commits into from
Jun 8, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jun 7, 2022

This PR fixes a duplicate cudatoolkit pinning issue we are seeing in cudf packages:
Screen Shot 2022-06-07 at 1 23 35 PM

This leads to following conda error:

Encountered problems while solving:
  - package cudf-22.08.00a220606-cuda_11_py39_g4d7595fb3f_113 requires cudatoolkit >=11.5,<12, but none of the providers can be installed

This PR also removes CC & CXX invocations, since we have switched to conda compilers: rapidsai/gpuci-build-environment#265

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 7, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner June 7, 2022 18:41
@galipremsagar galipremsagar self-assigned this Jun 7, 2022
@github-actions github-actions bot added the conda label Jun 7, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 7, 2022
@galipremsagar
Copy link
Contributor Author

@vyasr
Copy link
Contributor

vyasr commented Jun 7, 2022

I think the error was from having the ignore_run_exports_from in the requirements section. I don't believe it's supported there, only in the build section. It looks like you've already fixed this though.

@github-actions github-actions bot added the gpuCI label Jun 7, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@aec9007). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11070   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22733           
  Branches                ?        0           
===============================================
  Hits                    ?    19628           
  Misses                  ?     3105           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec9007...865b841. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a00cca6 into rapidsai:branch-22.08 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants