Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Index Join Tests on Default Precisions Deterministic #11451

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 3, 2022

Description

This PR fixes a flaky test introduced by #11272, cudf joins by default does not guarantee return orders and may lead to occasional test regression. This PR adds sort argument to make sure result is deterministic.

Note that index.union and index.intersection may also include random output ordering, but by default these methods sorts the result before returning so sort argument does not need to be modified.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner August 3, 2022 16:54
@isVoid isVoid requested review from shwina and brandon-b-miller and removed request for a team August 3, 2022 16:54
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 3, 2022
@isVoid isVoid added non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Aug 3, 2022
@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Aug 3, 2022
@isVoid isVoid added the bug Something isn't working label Aug 3, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Aug 3, 2022
@bdice bdice added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #11451 (bfb5906) into branch-22.08 (dcae9f7) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08   #11451   +/-   ##
=============================================
  Coverage         86.47%   86.47%           
=============================================
  Files               144      144           
  Lines             22856    22856           
=============================================
  Hits              19765    19765           
  Misses             3091     3091           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ajschmidt8 ajschmidt8 merged commit b2ae9a9 into rapidsai:branch-22.08 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants