-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CSV reader benchmarks with nvbench #11678
Refactor CSV reader benchmarks with nvbench #11678
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11678 +/- ##
===============================================
Coverage ? 85.89%
===============================================
Files ? 151
Lines ? 23534
Branches ? 0
===============================================
Hits ? 20214
Misses ? 3320
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@gpucibot merge |
Description
Closes #10941
This PR refactors the CSV reader benchmarks with nvbench and reduces the number of test cases by isolating data type, IO type, column selection, and row selection.
Example output of the new benchmarks:
Benchmark results
## csv_read_data_type[0] Quadro RTX 8000
csv_read_io
[0] Quadro RTX 8000
csv_read_column_selection
[0] Quadro RTX 8000
csv_read_row_selection
[0] Quadro RTX 8000
Checklist