Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] concat(): support sub-types and object wrappers #5879

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Aug 7, 2020

This PR makes concat() support sub-types and object wrappers of DataFrame, Series, etc.

This is motivated by rapidsai/dask-cuda#353, which wraps objects in a "proxy" class.
But the PR is generally useful for downstream projects that inherit from DataFrame, Series, etc.

@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@madsbk madsbk force-pushed the concat_sub_types branch from 785c231 to e9691d7 Compare August 7, 2020 14:13
@madsbk madsbk marked this pull request as ready for review August 7, 2020 16:32
@madsbk madsbk requested a review from a team as a code owner August 7, 2020 16:32
@madsbk madsbk changed the title concat(): support sub-types and object wrappers [REVIEW] concat(): support sub-types and object wrappers Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #5879 into branch-0.15 will increase coverage by 0.31%.
The diff coverage is 90.90%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5879      +/-   ##
===============================================
+ Coverage        84.12%   84.43%   +0.31%     
===============================================
  Files               80       80              
  Lines            13087    13416     +329     
===============================================
+ Hits             11009    11328     +319     
- Misses            2078     2088      +10     
Impacted Files Coverage Δ
python/cudf/cudf/core/reshape.py 88.67% <90.90%> (-0.43%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/custreamz/custreamz/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.75% <0.00%> (+0.02%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a691b26...53ed07c. Read the comment docs.

@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer Python Affects Python cuDF API. labels Aug 10, 2020
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2020
@kkraus14 kkraus14 merged commit b773c9e into rapidsai:branch-0.15 Aug 11, 2020
@madsbk madsbk deleted the concat_sub_types branch September 21, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants