Patch Thrust to workaround CUDA_CUB_RET_IF_FAIL macro clearing CUDA errors #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
libcudf
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
abellina
approved these changes
Aug 26, 2020
kkraus14
added
! - Hotfix
vuule
approved these changes
Aug 26, 2020
|
The same change has been posted to Thrust as NVIDIA/thrust#1264. |
harrism
approved these changes
Aug 26, 2020
kkraus14
approved these changes
Aug 26, 2020
kkraus14
added
5 - Merge After Dependencies
and removed
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #6098 +/- ##
===============================================
- Coverage 84.52% 84.51% -0.02%
===============================================
Files 82 82
Lines 13835 13835
===============================================
- Hits 11694 11692 -2
- Misses 2141 2143 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the libcudf build to patch Thrust after it is fetched. There's a bug in the
CUDA_CUB_RET_IF_FAILmacro that can cause errors to be cleared when called with acudaPeekAtLastError()argument which is very common in the thrust codebase.cub::Debugwill unconditionally clear the last CUDA error, so when the macro argument gets evaluated twice it ends up returning no error after the CUDA error was cleared, preventing the application from seeing the CUDA error.