-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interleave_columns for list type #8046
Implement interleave_columns for list type #8046
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8046 +/- ##
===============================================
+ Coverage 82.88% 82.91% +0.02%
===============================================
Files 103 103
Lines 17668 17865 +197
===============================================
+ Hits 14645 14812 +167
- Misses 3023 3053 +30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested. Good job on the tests.
@gpucibot merge |
This PR is trying to add java binding support for making List of List based on #8046. But the existing jni API makeList has already supported to create List of List, this PR just add unit tests for making list of list. Authors: - Bobby Wang (https://github.com/wbo4958) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #8111
This PR implements
lists::interleave_columns
that returns a single column by interleaving rows of the given table of list elements.For example:
Currently, only lists columns of one depth level are supported.