Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Java unit tests for making list of list #8111

Merged
merged 2 commits into from
May 6, 2021

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Apr 29, 2021

This PR is trying to add java binding support for making List of List based on #8046. But the existing jni API makeList has already supported to create List of List, this PR just add unit tests for making list of list.

@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Apr 29, 2021
@github-actions github-actions bot removed CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels May 5, 2021
@wbo4958
Copy link
Contributor Author

wbo4958 commented May 5, 2021

build

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #8111 (a22097c) into branch-0.20 (51336df) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8111      +/-   ##
===============================================
- Coverage        82.88%   82.86%   -0.03%     
===============================================
  Files              103      104       +1     
  Lines            17668    17884     +216     
===============================================
+ Hits             14645    14820     +175     
- Misses            3023     3064      +41     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <ø> (ø)
python/cudf/cudf/core/abc.py 91.66% <ø> (+0.17%) ⬆️
python/cudf/cudf/core/algorithms.py 82.35% <ø> (ø)
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 92.37% <ø> (+0.13%) ⬆️
python/cudf/cudf/core/column/column.py 88.20% <ø> (-0.44%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <ø> (-1.88%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 91.04% <0.00%> (-1.89%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4715c83...a22097c. Read the comment docs.

@wbo4958 wbo4958 added feature request New feature or request non-breaking Non-breaking change labels May 5, 2021
@wbo4958 wbo4958 marked this pull request as ready for review May 5, 2021 08:46
@wbo4958 wbo4958 requested a review from a team as a code owner May 5, 2021 08:46
@wbo4958 wbo4958 self-assigned this May 5, 2021
@jlowe jlowe added improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels May 5, 2021
@wbo4958
Copy link
Contributor Author

wbo4958 commented May 6, 2021

build

@jlowe jlowe changed the title add unit tests for making list of list add Java unit tests for making list of list May 6, 2021
@jlowe
Copy link
Contributor

jlowe commented May 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 96c0706 into rapidsai:branch-0.20 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants