Fix gather for sliced input structs column
#9218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
This was referenced Sep 11, 2021
|
Rerun tests. |
mythrocks
reviewed
Sep 13, 2021
|
Rerun tests. |
mythrocks
approved these changes
Sep 13, 2021
# Conflicts: # cpp/include/cudf/detail/gather.cuh # cpp/tests/copying/gather_struct_tests.cpp
harrism
approved these changes
Sep 17, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
This PR add support for struct type into the existing `drop_list_duplicates` API. This is the first time a nested type is supported in this function. Some more code cleanup has also been done. To be clear: Only structs of basic types and structs of structs are supported. Structs of lists are not, due to their complex nature. Closes #8972. Blocked by #9218 (it is merged). Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - https://github.com/nvdbaranec - Mark Harris (https://github.com/harrism) URL: #9202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
gatherAPI for structs columns when the input is a sliced column. Previously,gathercallschild_begin()andchild_end()to access the children column so if the input structs column is sliced then the output is incorrect.This closes #9213, and is blocked by #9194 due to conflict work.