Code

Nested struct binop comparison#9452

Code

Closed

rwlee wants to merge 79 commits intorapidsai:branch-22.06rapidsai/cudf:branch-22.06from rwlee:rwlee/struct_col_comparerwlee/cudf:rwlee/struct_col_compareCopy head branch name to clipboard

+725-80

Commits

Commits on Sep 30, 2021

• struct binop first pass

  rwlee

  committed
  262c2a2

  Copy full SHA for 262c2a2

Commits on Oct 14, 2021

• vector-vector nested struct comparison

  rwlee

  committed
  a865fe0

  Copy full SHA for a865fe0

Commits on Oct 16, 2021

• cleanup and simplify core code

  rwlee

  committed
  ce4440c

  Copy full SHA for ce4440c

Commits on Oct 20, 2021

• remove type dispatch and other code cleanup

  rwlee

  committed
  1472c5f

  Copy full SHA for 1472c5f

• move struct comparison to compiled binops code

  rwlee

  committed
  4a31fb6

  Copy full SHA for 4a31fb6

Commits on Oct 21, 2021

• improved testing, type checks, and skipped null value calculations

  rwlee

  committed
  ce2d727

  Copy full SHA for ce2d727

• cleanup

  rwlee

  committed
  10c95f9

  Copy full SHA for 10c95f9

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  12cd09e

  Copy full SHA for 12cd09e

• fix upmerge issues

  rwlee

  committed
  b6fa590

  Copy full SHA for b6fa590

Commits on Oct 22, 2021

• fix logic and improve documentation

  rwlee

  committed
  d64c1f9

  Copy full SHA for d64c1f9

• clean up logic for nulls

  rwlee

  committed
  57900da

  Copy full SHA for 57900da

• remove unecessary call to superimpose parent nulls

  rwlee

  committed
  f170149

  Copy full SHA for f170149

Commits on Oct 27, 2021

• PR fixes

  rwlee

  committed
  de129a1

  Copy full SHA for de129a1

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  5e84e89

  Copy full SHA for 5e84e89

• pr fixes

  rwlee

  committed
  b632192

  Copy full SHA for b632192

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  4266f8c

  Copy full SHA for 4266f8c

Commits on Nov 3, 2021

• restructure struct binop code and other pr fixes

  rwlee

  committed
  367ec07

  Copy full SHA for 367ec07

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  5a1f016

  Copy full SHA for 5a1f016

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  1f29168

  Copy full SHA for 1f29168

Commits on Nov 9, 2021

• full paths for includes

  rwlee

  committed
  1d6263e

  Copy full SHA for 1d6263e

• Merge branch 'branch-21.12' into rwlee/struct_col_compare

  rwlee

  committed
  97bd5e1

  Copy full SHA for 97bd5e1

Commits on Nov 11, 2021

• move to new TU and remove common code

  rwlee

  committed
  48d0355

  Copy full SHA for 48d0355

• fix logic errors and push down struct branching

  rwlee

  committed
  6cf0e16

  Copy full SHA for 6cf0e16

• remove deleted file from CMakeLists

  rwlee

  committed
  9ec2acf

  Copy full SHA for 9ec2acf

• Naming and comment fixes

  rwlee

  committed
  3016abf

  Copy full SHA for 3016abf

• naming

  rwlee

  committed
  b2a7973

  Copy full SHA for b2a7973

• style formatting

  rwlee

  committed
  191da69

  Copy full SHA for 191da69

Commits on Nov 12, 2021

• merge apply_binary_op and _impl implementation

  rwlee

  committed
  2cf2b28

  Copy full SHA for 2cf2b28

Commits on Nov 13, 2021

• all apply_binary_op calls call apply_binary_op_impl

  rwlee

  committed
  2b634c4

  Copy full SHA for 2b634c4

Commits on Nov 23, 2021

• common code path

  rwlee

  committed
  19f1afb

  Copy full SHA for 19f1afb

• explicit instantiation of struct_compare

  rwlee

  committed
  f316a0a

  Copy full SHA for f316a0a

• Merge branch 'branch-22.02' into rwlee/struct_col_compare

  rwlee

  committed
  c684ef1

  Copy full SHA for c684ef1

Commits on Nov 29, 2021

• streamline explicit instantiation

  rwlee

  committed
  7f36241

  Copy full SHA for 7f36241

• Merge remote-tracking branch 'pub/branch-22.02' into rwlee/struct_col_compare

  rwlee

  committed
  8cf0660

  Copy full SHA for 8cf0660

Commits on Dec 5, 2021

• remove op argument

  rwlee

  committed
  2abefd5

  Copy full SHA for 2abefd5

Commits on Dec 6, 2021

• documentation

  rwlee

  committed
  8cc05e2

  Copy full SHA for 8cc05e2

• Merge branch 'branch-22.02' into rwlee/struct_col_compare

  rwlee

  committed
  1bde152

  Copy full SHA for 1bde152

• Fix upmerge errors

  rwlee

  committed
  470acfe

  Copy full SHA for 470acfe

Commits on Dec 16, 2021

• Merge remote-tracking branch 'pub/branch-22.02' into rwlee/struct_col_compare

  rwlee

  committed
  ce21d90

  Copy full SHA for ce21d90

Commits on Feb 1, 2022

• Merge remote-tracking branch 'pub/branch-22.04' into rwlee/struct_col_compare

  rwlee

  committed
  83fa370

  Copy full SHA for 83fa370

Commits on Feb 4, 2022

• fix new ops from upmerge

  rwlee

  committed
  2b77739

  Copy full SHA for 2b77739

Commits on Feb 8, 2022

• Fix floating point nan handling in struct comparison binops

  rwlee

  committed
  de09cec

  Copy full SHA for de09cec

• Merge remote-tracking branch 'pub/branch-22.04' into rwlee/struct_col_compare

  rwlee

  committed
  8ad9545

  Copy full SHA for 8ad9545

Commits on Feb 9, 2022

• fix formatting

  rwlee

  committed
  251d607

  Copy full SHA for 251d607

Commits on Feb 14, 2022

• fix copyright

  rwlee

  committed
  703aaf8

  Copy full SHA for 703aaf8

• fix accidently deletd function

  rwlee

  committed
  43e451b

  Copy full SHA for 43e451b

Commits on Feb 15, 2022

• style fix

  rwlee

  committed
  9ec4a41

  Copy full SHA for 9ec4a41

• copyright fix

  rwlee

  committed
  201a89b

  Copy full SHA for 201a89b

• Merge remote-tracking branch 'pub/branch-22.04' into rwlee/struct_col_compare

  rwlee

  committed
  cc164d6

  Copy full SHA for cc164d6

• fix cmake style

  rwlee

  committed
  1bb1534

  Copy full SHA for 1bb1534

Commits on Feb 16, 2022

• re-add missing function name

  rwlee

  committed
  6c6c8ab

  Copy full SHA for 6c6c8ab

• style fix

  rwlee

  committed
  42e58ae

  Copy full SHA for 42e58ae

Commits on Feb 19, 2022

• Fix struct equality binop comparisons

  rwlee

  committed
  475c896

  Copy full SHA for 475c896

Commits on Mar 7, 2022

• PR reviews

  rwlee

  committed
  1dae04a

  Copy full SHA for 1dae04a

Commits on Mar 8, 2022

• Merge remote-tracking branch 'pub/branch-22.04' into rwlee/struct_col_compare

  rwlee

  committed
  62224cf

  Copy full SHA for 62224cf

Commits on Mar 22, 2022

• refactor row comparison operators into common spaceship operator

  rwlee

  committed
  a35600d

  Copy full SHA for a35600d

• Merge remote-tracking branch 'pub/branch-22.04' into rwlee/struct_col_compare

  rwlee

  committed
  b6f0397

  Copy full SHA for b6f0397

Commits on Mar 29, 2022

• first pass, test failures

  rwlee

  committed
  fcc1dd2

  Copy full SHA for fcc1dd2

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/struct_col_compare

  rwlee

  committed
  5abf2a8

  Copy full SHA for 5abf2a8

Commits on Apr 16, 2022

• Refactor struct binop comparison to use experimental ops

  rwlee

  committed
  9d50ac0

  Copy full SHA for 9d50ac0

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/struct_col_compare

  rwlee

  committed
  8628c24

  Copy full SHA for 8628c24

Commits on Apr 18, 2022

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/struct_col_compare

  rwlee

  committed
  a836a96

  Copy full SHA for a836a96

Commits on May 2, 2022

• fix performance regression and code cleanup

  rwlee

  committed
  a537805

  Copy full SHA for a537805

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/struct_col_compare

  rwlee

  committed
  f7af41f

  Copy full SHA for f7af41f

Commits on May 3, 2022

• fix merge errors

  rwlee

  committed
  1af4643

  Copy full SHA for 1af4643

• Merge remote-tracking branch 'upstream/branch-22.06' into rwlee/struct_col_compare

  bdice

  committed
  4d929d9

  Copy full SHA for 4d929d9

• Revert include changes.

  bdice

  committed
  2298988

  Copy full SHA for 2298988

Commits on May 4, 2022

• split off weak ordering row operator changes

  rwlee

  committed
  bf1c6ee

  Copy full SHA for bf1c6ee

• device_row_comparator private with friend class

  rwlee

  committed
  5d87db2

  Copy full SHA for 5d87db2

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/row_op_split

  rwlee

  committed
  fd716b9

  Copy full SHA for fd716b9

Commits on May 6, 2022

• device_less conversion to templated struct

  rwlee

  committed
  2dd2045

  Copy full SHA for 2dd2045

Commits on May 9, 2022

• fold parameter pack

  rwlee

  committed
  7ba960e

  Copy full SHA for 7ba960e

Commits on May 10, 2022

• Apply suggestions from code review

  Show description for 84833e7
  

  rwlee

  and

  bdice

  authored
  84833e7

  Copy full SHA for 84833e7

• Merge remote-tracking branch 'pub/branch-22.06' into rwlee/struct_col_compare

  rwlee

  committed
  a944b4f

  Copy full SHA for a944b4f

• fix code style

  rwlee

  committed
  4d197ea

  Copy full SHA for 4d197ea

• Merge branch 'rwlee/row_op_split' of github.com:rwlee/cudf into rwlee/row_op_split

  rwlee

  committed
  08092fe

  Copy full SHA for 08092fe

• Merge branch 'rwlee/row_op_split' into rwlee/struct_col_compare

  rwlee

  committed
  d8986c5

  Copy full SHA for d8986c5

• fix code format

  rwlee

  committed
  548dcf1

  Copy full SHA for 548dcf1

Commits on May 11, 2022

• Merge remote-tracking branch 'upstream/branch-22.06' into rwlee/struct_col_compare

  bdice

  committed
  1dd1159

  Copy full SHA for 1dd1159