Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] PropertyGraph & MGPropertyGraph renumber_vertices/edges_by_type Fails to Preserve Data Type #3069

Closed
alexbarghi-nv opened this issue Dec 8, 2022 · 0 comments · Fixed by #2996
Closed

[FIX] PropertyGraph & MGPropertyGraph renumber_vertices/edges_by_type Fails to Preserve Data Type #3069

alexbarghi-nv opened this issue Dec 8, 2022 · 0 comments · Fixed by #2996
Assignees
@alexbarghi-nv
Milestone
23.02

Comments

@alexbarghi-nv
Copy link
Member

Currently, renumber_vertices_by_type and renumber_edges_by_type upcast the index to int64. This causes errors when calling sampling since the index dtype doesn't match the src/dst dtype.

This issue should be fixed by saving the original dtype and forcing the dtype of the new index to match the old dtype using astype, or a similar solution.
@alexbarghi-nv alexbarghi-nv added this to the 23.02 milestone Dec 8, 2022
@alexbarghi-nv alexbarghi-nv self-assigned this Dec 8, 2022
@alexbarghi-nv alexbarghi-nv mentioned this issue Dec 9, 2022
Merged
5 tasks
@rapids-bot rapids-bot bot closed this as completed in ef52c5c Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
None yet
Projects
None yet
Milestone
23.02
Development

Successfully merging a pull request may close this issue.

Use Vertex ID Offsets in CuGraphStorage alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv