Rewrite copy_type_metadata to reuse the inherited method and handle geocolumns specifically.
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
3 - Ready for Review
harrism
changed the title
copy_type_metadata to reuse the inherited method and handles geocolumns specifically.copy_type_metadata to reuse the inherited method and handle geocolumns specifically.
harrism
approved these changes
Sep 21, 2022
thomcom
requested changes
Sep 21, 2022
thomcom
approved these changes
Sep 21, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up rapidsai/cudf#11687 to adapt to the change to
_copy_type_metadatainterface. This PR should unblock CI.Checklist