Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dask-config CLI for clarity #1038

Closed
jakirkham opened this issue Nov 11, 2022 · 7 comments · Fixed by #981
Closed

Rename dask-config CLI for clarity #1038

jakirkham opened this issue Nov 11, 2022 · 7 comments · Fixed by #981

Comments

@jakirkham
Copy link
Member

Currently Dask-CUDA exposes a CLI called dask-config

dask-config=dask_cuda.cli.dask_config:go

That points to a similarly named module

As it may not be clear that this CLI comes from Dask-CUDA (say in a busy environment), wonder if it makes sense to rename this for clarity

@wence-
Copy link
Contributor

wence- commented Nov 11, 2022

Additionally, this is broken since the dask_config module doesn't advertise a go function.

@jakirkham
Copy link
Member Author

This raises another good question. Is it being used (considering some functionality in it is currently broken and I'm guessing we are not hearing about it)?

@wence-
Copy link
Contributor

wence- commented Nov 11, 2022

It was only recently introduced, so probably no-one knows about it yet. I recommend renaming (via the new dask commandline tool) to dask cuda show-cluster-config or similar.

@quasiben
Copy link
Member

+1 to renaming

@jakirkham
Copy link
Member Author

jakirkham commented Nov 14, 2022

In PR ( #981 ), @jacobtomlinson suggested using dask cuda config ( #981 (comment) )

@caryr35 caryr35 added this to dask-cuda Dec 8, 2022
@jakirkham
Copy link
Member Author

Did we settle on a name?

cc @quasiben

@jacobtomlinson
Copy link
Member

Either my or @wence-'s suggestions seem fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants