Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove deprecated cusparse APIs from cusparse_wrappers #967

Closed
cjnolet opened this issue Oct 31, 2022 · 1 comment
Closed

[FEA] Remove deprecated cusparse APIs from cusparse_wrappers #967

cjnolet opened this issue Oct 31, 2022 · 1 comment
Assignees
@lowener
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Oct 31, 2022 •
edited
Loading

A few deprecated APIs have been removed from the cusparse wrappers, such as gemmi, gathr, and csrgemm2.

The cusparse_wrappers were intentionally moved to the detail API but haven't been fully replaced w/ a public API facade yet so there are places in both RAFT and cuml which are still referencing these wrappers directly. This should make it easier to fix this change, though, because we might be able to back the implementations of the wrapped functions w/ the non-deprecated versions in the meantime (e.g. gemmi->spmm, etc...), migrate everything over to the new function names, then eventually remove the old functions from RAFT altogether.

cc @robertmaynard
@cjnolet cjnolet added the feature request New feature or request label Oct 31, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Nov 9, 2022

Closed by #989

@cjnolet cjnolet closed this as completed Nov 9, 2022
Repository owner moved this from In Progress to Done in VS/ML/DM Primitives Release Board Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowener lowener

Labels
feature request New feature or request
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjnolet @lowener