Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] rapids_cython_create_modules() should document the fact that it reads CYTHON_FLAGS #721

Open
Jacobfaib opened this issue Nov 27, 2024 · 1 comment
Labels
? - Needs Triage Need team to review and classify doc Documentation

Comments

@Jacobfaib
Copy link
Contributor

rapids_cython_create_modules() inspects the variable CYTHON_FLAGS. It's not obvious that this specific variable is consulted.

This should probably be documented, or perhaps exposed as an additional argument to rapids_cython_create_modules(). I guess it is supposed to mimic the CMAKE_CXX_FLAGS and friends. But if that is the case, the user might expect to set e.g. CMAKE_CYTHON_FLAGS or CMAKE_CYTHON_FLAGS_DEBUG.

@Jacobfaib Jacobfaib added ? - Needs Triage Need team to review and classify doc Documentation labels Nov 27, 2024
@vyasr
Copy link
Contributor

vyasr commented Dec 10, 2024

I agree, this would be good to do. If you have a few moments we'd love a contribution! I originally chose CYTHON_FLAGS to match the behavior of the legacy scikit-build's Cython CMake layer, but I'd welcome improvements to that design now that we're pretty much rolling our own Cython invocations. I do hope to eventually switch over to using cython-cmake (and longer-term a native Cython solution) so I'd also be happy to propose any such improvements upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify doc Documentation
Projects
None yet
Development

No branches or pull requests

2 participants