Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error log improvements for verifying vulnerability report #1220

Closed
1 task
yizha1 opened this issue Dec 15, 2023 · 2 comments
Closed
1 task

Error log improvements for verifying vulnerability report #1220

yizha1 opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yizha1
Copy link
Collaborator

yizha1 commented Dec 15, 2023

What would you like to be added?

I set up a policy to block images that are not compliant with vulnerabilities standards by verifying vulnerability reports.

Case-1: No vulnerability report is attached to an image
The error message is like "verification failed: Error: referrers not found, Code: REFERRERS_NOT_FOUND, Component Type: executor", for normal users, they do not know what referrers mean. It will not help users to understand what happened

Improvement: at least we can add the information of artifactType, so that we know which artifact as the referrers is missing.

Case-2: Verify an image with vulnerabilities of disallowed severities

The message field of the verifier reports is "vulnerability report validation failed" which is very general, the severity violations include a full list of vulnerabilities from vulnerability report, which could be a long list that can flush out the logs

Improvement: The message can be more intuitive, like "Vulnerability report validation failed: Found vulnerabilities with severities in the deny list", in the extension, it could be a list of "CVE and Severity".

Case-3: Verify an image with vulnerabilities in the denylist

Similar to Case-2, the value in the message field is too general message": "vulnerability report validation failed".

Improvement: The message can be more intuitive, like "Vulnerability report validation failed: Found CVEs in the deny list"

Anything else you would like to add?

N/A

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@yizha1 yizha1 added enhancement New feature or request triage Needs investigation labels Dec 15, 2023
@susanshi susanshi added this to the v1.2.0 milestone Dec 19, 2023
@susanshi susanshi removed the triage Needs investigation label Dec 21, 2023
@akashsinghal akashsinghal self-assigned this Jan 2, 2024
@akashsinghal
Copy link
Collaborator

This issue was largely fixed by #1238. However, case-1 is a longer tail fix since it requires changes at the executor level.

@susanshi
Copy link
Collaborator

@akashsinghal lets close this one and open specific executor level error improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants