Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semversioner check should assert that the current branch contains a change document #48

Open
darthtrevino opened this issue May 2, 2024 · 1 comment · May be fixed by #50
Open

semversioner check should assert that the current branch contains a change document #48

darthtrevino opened this issue May 2, 2024 · 1 comment · May be fixed by #50

Comments

@darthtrevino
Copy link
Contributor

Currently semversioner check asserts that a change document has been created. And initially it works great for that, but imagine this flow:

In PR 1, Cyril makes low-impact changes. semversioner check catches that he needs a change document. Cyril uses semversioner add-change -t patch -d ...

In PR2, Pat makes a higher-impact change. They forget to commit a change document, but semversioner check will pass, because a change document exists from Cyril's PR.

Ideally, semversioner check would cause Pat's PR to fail as well because their changes have semver impact that should be documented independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant