You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched the issues and found no similar issues.
KubeRay Component
ray-operator
What happened + What you expected to happen
We need to revisit all shallow copy of struct in KubeRay because the following reasons:
(1) Shallow copy of a go struct is not encouraged, and see article for more details.
(2) Take #714 as an example, shallow copy of struct causes worker pods may be created with different configurations.
(3) "shallow copy of struct" I mentioned in (2) is not totally accurate. A struct is by default deep copied, but elements in the struct may be shallow copied or deep copied. See Shallow copy and Deep copy in Go for more details.
Search before asking
KubeRay Component
ray-operator
What happened + What you expected to happen
We need to revisit all shallow copy of struct in KubeRay because the following reasons:
(1) Shallow copy of a go struct is not encouraged, and see article for more details.
(2) Take #714 as an example, shallow copy of
struct
causes worker pods may be created with different configurations.(3) "shallow copy of struct" I mentioned in (2) is not totally accurate. A struct is by default deep copied, but elements in the struct may be shallow copied or deep copied. See Shallow copy and Deep copy in Go for more details.
Reproduction script
See #714
Anything else
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: