Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [CI] Make sure CI handles all code generation. #720

Closed
1 of 2 tasks
DmitriGekhtman opened this issue Nov 14, 2022 · 0 comments
Closed
1 of 2 tasks

[Bug] [CI] Make sure CI handles all code generation. #720

DmitriGekhtman opened this issue Nov 14, 2022 · 0 comments
Labels
bug Something isn't working ci P1 Issue that should be fixed within a few weeks

Comments

@DmitriGekhtman
Copy link
Collaborator

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ci

What happened + What you expected to happen

We still have situations where PRs are merged without complete code generation.
This should be fixed in an automated way.

See https://github.com/ray-project/kuberay/pull/714/files#r1021925146

Reproduction script

See https://github.com/ray-project/kuberay/pull/714/files#r1021925146

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@DmitriGekhtman DmitriGekhtman added the bug Something isn't working label Nov 14, 2022
@DmitriGekhtman DmitriGekhtman mentioned this issue Nov 14, 2022
Merged
4 tasks
@DmitriGekhtman DmitriGekhtman added the P1 Issue that should be fixed within a few weeks label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ci P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevin85421 @DmitriGekhtman