Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] kuberay apiserver need UT for new added apis of rayjobs and rayservice #754

Closed
2 tasks done
scarlet25151 opened this issue Nov 22, 2022 · 3 comments
Closed
2 tasks done
Labels
apiserver enhancement New feature or request P1 Issue that should be fixed within a few weeks

Comments

@scarlet25151
Copy link
Collaborator

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

some bugs happened like #734 because of lacking some UT when adding the logic and maybe some manually e2e check may not find the bugs add effort for further bug fix, we need add more detail UTs in kuberay-apiserver to add stability.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@scarlet25151 scarlet25151 added enhancement New feature or request apiserver P1 Issue that should be fixed within a few weeks labels Nov 22, 2022
@scarlet25151 scarlet25151 added this to the v0.4.0 release milestone Nov 22, 2022
@scarlet25151
Copy link
Collaborator Author

Here after offline talk with @wilsonwang371 we think we need more precise unit testing to check whether the apiserver generated rayservice and rayjob works well in kubernetes cluster, it may not be ready for both rayservice and rayjob before the release cut this week, we may propose to have it in the next release, WDYT @DmitriGekhtman?

@DmitriGekhtman
Copy link
Collaborator

That sounds fine to me.
I think the actual action item ahead of the release is to clearly document that RayJobs and RayServices are experimental.

@kevin85421 kevin85421 removed this from the v0.5.0 release milestone Mar 3, 2023
@kevin85421
Copy link
Member

@blublinsky has identified that this KubeRay API server issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apiserver enhancement New feature or request P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

3 participants