Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bitwarden Vault] Generate Password command does not respect options #14910

Closed
jose-elias-alvarez opened this issue Oct 14, 2024 · 5 comments
Closed
Labels
bug Something isn't working extension: bitwarden Issues related to the bitwarden extension extension Issues related to one of the extensions in the Store status: stalled Stalled due inactivity

Comments

@jose-elias-alvarez
Copy link
Contributor

Extension

https://www.raycast.com/jomifepe/bitwarden

Raycast Version

1.84.2

macOS Version

15.0.1

Description

When running the Generate Password command from Bitwarden extension, the checked status of the "Numeric characters" and "Special characters" options are not respected, and the options always behave as if enabled.

Weirdly, I forked the extension and ran it locally to investigate, but my local copy doesn't have the same issue, and the options are indeed respected. (Even more weirdly, the generation step seems to take less time.)

I'm running the latest version of Bitwarden and the CLI (2024.9.0).

Steps To Reproduce

  1. Install and set up the extension
  2. Run the Generate Password command

Current Behaviour

Both numeric characters and special characters are always included in the generated password (the lowercase and uppercase options do seem to be respected).

Expected Behaviour

The options are respected, and the relevant character types are included in or excluded from the generated password based on their values.

@jose-elias-alvarez jose-elias-alvarez added bug Something isn't working extension Issues related to one of the extensions in the Store labels Oct 14, 2024
@raycastbot raycastbot added the extension: bitwarden Issues related to the bitwarden extension label Oct 14, 2024
@raycastbot
Copy link
Collaborator

Thank you for opening this issue!

🔔 @jomifepe @daniel-stoneuk @andreaselia @pernielsentikaer @eth-p @YamenSharaf @undefinedzack @anirudhganwal06 @ivaarsson you might want to have a look.

💡 Author and Contributors commands

The author and contributors of jomifepe/bitwarden can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot close as not planned Closes the issue as not planned.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.
  • @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

@jose-elias-alvarez
Copy link
Contributor Author

A similar issue was raised in #13906, but it doesn't seem like the fix fully resolved it (the last comment there also indicates that at least one other person is still experiencing the same problem).

@raycastbot
Copy link
Collaborator

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Dec 3, 2024
@raycastbot
Copy link
Collaborator

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

@raycastbot raycastbot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
@jose-elias-alvarez
Copy link
Contributor Author

For future reference: after further investigation I suspect this is actually an upstream issue and reported it at bitwarden/clients/issues/13657. Once that's fixed, I believe the generate command here will work as expected without any further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension: bitwarden Issues related to the bitwarden extension extension Issues related to one of the extensions in the Store status: stalled Stalled due inactivity
Projects
None yet
Development

No branches or pull requests

2 participants