Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray.so] doesn't get a correct theme in the url #16031

Closed
AutomationD opened this issue Dec 24, 2024 · 6 comments · Fixed by #16081
Closed

[ray.so] doesn't get a correct theme in the url #16031

AutomationD opened this issue Dec 24, 2024 · 6 comments · Fixed by #16081
Labels
bug Something isn't working extension: ray-so Issues related to the ray-so extension extension Issues related to one of the extensions in the Store

Comments

@AutomationD
Copy link

Extension

https://www.raycast.com/garrett/ray-so

Raycast Version

1.88.4

macOS Version

15.1.1

Description

When submitting a request to ray.so theme is not honored. I'm selecting a theme, say "Forest"
image
The URL (and thus ray so theme) is selected as Candy
image

Steps To Reproduce

  1. Create a new snippet with a theme "Forest"
  2. Observe theme not match

Current Behaviour

Theme not passed in the url

Expected Behaviour

Theme is passed in the url

@AutomationD AutomationD added bug Something isn't working extension Issues related to one of the extensions in the Store labels Dec 24, 2024
@raycastbot raycastbot added the extension: ray-so Issues related to the ray-so extension label Dec 24, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 24, 2024

Thank you for opening this issue!

🔔 @gt-codes @RSO @dgrzedzielski @emlez @samuelkraft @benoitgrelard @sdorra you might want to have a look.

💡 Author and Contributors commands

The author and contributors of garrett/ray-so can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot close as not planned Closes the issue as not planned.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.
  • @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

@AutomationD AutomationD changed the title [ray.so] ... [ray.so] doesn't get a correct theme in the url Dec 24, 2024
@dgrzedzielski
Copy link
Contributor

Works for me

@AutomationD
Copy link
Author

Works for me

Here's a video. Am I doing anything wrong?

RaySo.mov

@dgrzedzielski
Copy link
Contributor

Oh I see the issue, if you keep the default theme it's not properly passed to the ray.so in url

@dgrzedzielski
Copy link
Contributor

I've opened PR that should fix it #16081, thanks for reporting 🫡

@AutomationD
Copy link
Author

Thanks Dominik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension: ray-so Issues related to the ray-so extension extension Issues related to one of the extensions in the Store
Projects
None yet
3 participants