-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clipboard History] Ignore passwords copied from browser extension: Bitwarden (password manager) #4927
Comments
We could not find the extension related to this issue. Please update the issue with the correct link to the extension. |
@raycastbot seems to be incorrect in this case |
this is because the clipboard history is not an extension, it is a built-in feature in Raycast. |
Where should I post the issue, then? |
I'm a newbie on this repo (and in GitHub in general) so I have no idea, I can't help you. Ask people on the slack channel maybe :) |
Hi @amunrarara |
@zalewskigrzegorz Thanks for that, I didn't know about that feature. Unfortunately, it still does not cover the Bitwarden Chrome Extension, which I use 99% of the time. Is there a way to prevent Clipboard History from reading specific Chrome Extensions? It would make sense to include browser extensions in this tool, since most users are going to be using in-browser password managers |
This issue has been automatically closed due to inactivity. Feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss this. |
I'm still hoping this issue can be resolved! |
Mmh interesting... I dug into the source code of the browser extension of Bitwarden. Here is the code where they copy the text/password. It gets copied as a plain text, which means that Raycast doesn't have a way to distinguish it from other items. Other macOS apps mark the pasteboard content as transient (more here). This allows Raycast to identify if content was transient and ignores it saving it in the Clipboard History. Few questions:
|
That's some excellent code-sleuthing, @thomaspaulmann. Is question #1 directed toward me? I'm unsure how to respond to that particular question; I'm not intending to open a PR for Raycast currently, I'm a bit work-swamped at the moment unfortunately. Could change in the future though; this tool rocks. As for #2, I confirmed that passwords copied from the Bitwarden browser extension are not being removed from my Raycast ClipboardHistory. I've attached a screenshot of what the info block from the password itself looks like; I'm using the Bitwarden extension within the Vivaldi browser. Although macOS apps marks the pasteboard content as transient, and the extension copies as plain text, is there a way to view that the source of the copy is a Vivaldi extension, and lift particular information from it? Or, some sort of event listener that Bitwarden emits on-copy that can be listened to? Interesting to note, there is a setting in Bitwarden that auto-clears copied passwords from my standard clipboard based on a selected time in the Settings menu. That might be a clue to wiring it up to Raycast. |
(Also, this issue was marked as Closed by the robot, can it be re-opened?) |
Could we disable the clipboard history for Raycast's extensions as well? I use the Bitwarden extension a lot and it would be helpful to not have the clipboard history saving my passwords from this source. |
We released a new API to mark copied content as transient. Looks like the Bitwarden extension wasn't updated. @guspimentel want to go ahead making the change?
@amunrarara unfortunately that isn't possible.
@amunrarara did you enable this setting and notice if Raycast removes the item? I believe we have/had logic for this in place. So maybe that's a bug after-all?! |
@thomaspaulmann I have no idea how to do this 😂 |
Hey, I created a PR for the Bitwarden extension to use the transient flag when copying, should be available soon. |
I have this enabled, yes, but Raycast does not adhere to it! |
This issue has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊 |
This issue has been automatically closed due to inactivity. Feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss this. |
Extension
https://www.raycast.com/extensions/clipboard-history
Description
Clipboard History's description page states:
"Passwords copied from any password managers and other transient data are ignored by default."
However, passwords copied from Bitwarden are, in fact, showing up within Clipboard History.
Tested with MacOS desktop app, as well as Vivaldi (Chromium) browser extension.
Who will benefit from this feature?
Bitwarden users
Anything else?
No response
The text was updated successfully, but these errors were encountered: