Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clipboard History] Ignore passwords copied from browser extension: Bitwarden (password manager) #4927

Closed
amunrarara opened this issue Feb 23, 2023 · 19 comments
Labels
extension Issues related to one of the extensions in the Store feature request New feature or improvement status: stalled Stalled due inactivity

Comments

@amunrarara
Copy link

Extension

https://www.raycast.com/extensions/clipboard-history

Description

Clipboard History's description page states:

"Passwords copied from any password managers and other transient data are ignored by default."

However, passwords copied from Bitwarden are, in fact, showing up within Clipboard History.

Tested with MacOS desktop app, as well as Vivaldi (Chromium) browser extension.

Who will benefit from this feature?

Bitwarden users

Anything else?

No response

@amunrarara amunrarara added extension Issues related to one of the extensions in the Store feature request New feature or improvement labels Feb 23, 2023
@raycastbot
Copy link
Collaborator

We could not find the extension related to this issue. Please update the issue with the correct link to the extension.

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Feb 23, 2023
@amunrarara
Copy link
Author

@raycastbot seems to be incorrect in this case

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Feb 24, 2023
@orimandel
Copy link
Contributor

@raycastbot seems to be incorrect in this case

this is because the clipboard history is not an extension, it is a built-in feature in Raycast.

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Feb 25, 2023
@amunrarara amunrarara reopened this Feb 25, 2023
@amunrarara
Copy link
Author

@raycastbot seems to be incorrect in this case

this is because the clipboard history is not an extension, it is a built-in feature in Raycast.

Where should I post the issue, then?

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Feb 25, 2023
@orimandel
Copy link
Contributor

I'm a newbie on this repo (and in GitHub in general) so I have no idea, I can't help you. Ask people on the slack channel maybe :)

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Feb 28, 2023
@zalewskigrzegorz
Copy link

Hi @amunrarara
I think you can set up it by yourself.
image

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Mar 2, 2023
@amunrarara
Copy link
Author

amunrarara commented Mar 3, 2023

@zalewskigrzegorz Thanks for that, I didn't know about that feature.

Unfortunately, it still does not cover the Bitwarden Chrome Extension, which I use 99% of the time. Is there a way to prevent Clipboard History from reading specific Chrome Extensions?

It would make sense to include browser extensions in this tool, since most users are going to be using in-browser password managers

@raycastbot raycastbot added status: stalled Stalled due inactivity and removed status: stalled Stalled due inactivity labels Mar 3, 2023
@raycastbot
Copy link
Collaborator

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

@raycastbot raycastbot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2023
@amunrarara
Copy link
Author

I'm still hoping this issue can be resolved!

@thomaspaulmann
Copy link
Member

Mmh interesting... I dug into the source code of the browser extension of Bitwarden. Here is the code where they copy the text/password. It gets copied as a plain text, which means that Raycast doesn't have a way to distinguish it from other items.

Other macOS apps mark the pasteboard content as transient (more here). This allows Raycast to identify if content was transient and ignores it saving it in the Clipboard History.

Few questions:

  • Could we add something similar to the open source extension? This would improve the extension in general. AFAIK you can copy custom ClipboardItem but unsure about the type of the data.
  • Could you test if the password gets removed from your clipboard? So simply copy a password from the extension, then wait a few minutes and see if you can still paste it into other applications with "⌘ + V" (not from the clipboard history).

@amunrarara
Copy link
Author

amunrarara commented Mar 15, 2023

That's some excellent code-sleuthing, @thomaspaulmann.

Is question #1 directed toward me? I'm unsure how to respond to that particular question; I'm not intending to open a PR for Raycast currently, I'm a bit work-swamped at the moment unfortunately. Could change in the future though; this tool rocks.

As for #2, I confirmed that passwords copied from the Bitwarden browser extension are not being removed from my Raycast ClipboardHistory. I've attached a screenshot of what the info block from the password itself looks like; I'm using the Bitwarden extension within the Vivaldi browser.

Although macOS apps marks the pasteboard content as transient, and the extension copies as plain text, is there a way to view that the source of the copy is a Vivaldi extension, and lift particular information from it? Or, some sort of event listener that Bitwarden emits on-copy that can be listened to?

Interesting to note, there is a setting in Bitwarden that auto-clears copied passwords from my standard clipboard based on a selected time in the Settings menu. That might be a clue to wiring it up to Raycast.

Screen Shot 2023-03-15 at 12 35 12 PM

Screen Shot 2023-03-15 at 12 39 47 PM

@amunrarara
Copy link
Author

(Also, this issue was marked as Closed by the robot, can it be re-opened?)

@amunrarara amunrarara changed the title [Clipboard History] Ignore passwords copied from Bitwarden (password manager) [Clipboard History] Ignore passwords copied from browser extension: Bitwarden (password manager) Mar 15, 2023
@guspimentel
Copy link

Could we disable the clipboard history for Raycast's extensions as well? I use the Bitwarden extension a lot and it would be helpful to not have the clipboard history saving my passwords from this source.

@thomaspaulmann
Copy link
Member

Could we disable the clipboard history for Raycast's extensions as well? I use the Bitwarden extension a lot and it would be helpful to not have the clipboard history saving my passwords from this source.

We released a new API to mark copied content as transient. Looks like the Bitwarden extension wasn't updated. @guspimentel want to go ahead making the change?

is there a way to view that the source of the copy is a Vivaldi extension, and lift particular information from it? Or, some sort of event listener that Bitwarden emits on-copy that can be listened to?

@amunrarara unfortunately that isn't possible.

Interesting to note, there is a setting in Bitwarden that auto-clears copied passwords from my standard clipboard based on a selected time in the Settings menu. That might be a clue to wiring it up to Raycast.

@amunrarara did you enable this setting and notice if Raycast removes the item? I believe we have/had logic for this in place. So maybe that's a bug after-all?!

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Mar 15, 2023
@guspimentel
Copy link

We released a new API to mark copied content as transient. Looks like the Bitwarden extension wasn't updated. @guspimentel want to go ahead making the change?

@thomaspaulmann I have no idea how to do this 😂

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Mar 15, 2023
@jomifepe
Copy link
Contributor

jomifepe commented Mar 16, 2023

Could we disable the clipboard history for Raycast's extensions as well? I use the Bitwarden extension a lot and it would be helpful to not have the clipboard history saving my passwords from this source.

We released a new API to mark copied content as transient. Looks like the Bitwarden extension wasn't updated. @guspimentel want to go ahead making the change?

Hey, I created a PR for the Bitwarden extension to use the transient flag when copying, should be available soon.

@raycastbot raycastbot added status: stalled Stalled due inactivity and removed status: stalled Stalled due inactivity labels Mar 16, 2023
@amunrarara
Copy link
Author

@amunrarara did you enable this setting and notice if Raycast removes the item? I believe we have/had logic for this in place. So maybe that's a bug after-all?!

I have this enabled, yes, but Raycast does not adhere to it!

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Mar 16, 2023
@raycastbot
Copy link
Collaborator

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label May 8, 2023
@raycastbot
Copy link
Collaborator

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

@raycastbot raycastbot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Issues related to one of the extensions in the Store feature request New feature or improvement status: stalled Stalled due inactivity
Projects
None yet
Development

No branches or pull requests

7 participants