Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address performance penalty when source is smaller than one or more requested sizes #250

Open
rbuchberger opened this issue May 10, 2021 · 1 comment

Comments

@rbuchberger
Copy link
Owner

Currently, if a source image is smaller than one of the requested images, we start the "generate a new image" process on every site build. Only after calculating a hash do we check sizes and discover the source is too small. The result is a moderate performance penalty for repeated builds on sites with many such images, even with fast_build enabled.

Solution: Check the image size first, then calculate a hash.

@Syonyk
Copy link

Syonyk commented Aug 30, 2021

Following, this definitely seems to add some time to my blog renders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants