Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two ARG completion items are displayed when snippets are not supported #137

Closed
rcjsuen opened this issue Aug 6, 2017 · 3 comments
Closed
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 6, 2017

When snippets are enabled, two different ARG completion items are displayed. One is for ARG name and the other is for ARG name=defaultValue. This makes sense because the user can choose which one to use.

However, if snippets are disabled, both completion items perform the same thing and only append ARG into the document. From a coding point of view this makes both completion items effectively identical so only one ARG completion item should be displayed if snippetSupport is false.

@rcjsuen rcjsuen added the bug label Aug 6, 2017
@rcjsuen rcjsuen self-assigned this Aug 6, 2017
@rcjsuen rcjsuen closed this as completed in 9680fb4 Aug 6, 2017
@prabirshrestha
Copy link

Cloud you publish the new package version to npm?

@rcjsuen
Copy link
Owner Author

rcjsuen commented Aug 7, 2017

@prabirshrestha I have published v0.0.5 to npm.

@prabirshrestha
Copy link

Thanks. It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants