Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server doesn't specify a section when sending workspace/configuration requests #182

Closed
rcjsuen opened this issue Oct 5, 2017 · 0 comments
Closed

Server doesn't specify a section when sending workspace/configuration requests #182

rcjsuen opened this issue Oct 5, 2017 · 0 comments
Assignees
@rcjsuen
Labels
bug

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 5, 2017

Instead of sending in an empty string, we should be setting docker.languageserver.diagnostics as the section's name in the request's parameter.

https://github.com/rcjsuen/dockerfile-language-server-nodejs/blob/4349ec82e0db149f65240b3ec8a30b1b2c99476d/src/server.ts#L205-L212

https://github.com/rcjsuen/dockerfile-language-server-nodejs/blob/4349ec82e0db149f65240b3ec8a30b1b2c99476d/src/server.ts#L222-L229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen