Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable references that span multiple lines do not consider lines after the first #193

Closed
rcjsuen opened this issue Nov 13, 2017 · 0 comments
Closed

Variable references that span multiple lines do not consider lines after the first #193

rcjsuen opened this issue Nov 13, 2017 · 0 comments
Assignees
@rcjsuen
Labels
bug

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Nov 13, 2017 

FROM scratch
ENV abcd=8080
EXPOSE ${ab\
cd}

If a variable's name spans multiple lines, attempting to interact with the latter part of the name on the lines after the first will not work. textDocument/documentHighlight only highlights the first line and textDocument/definition, textDocument/hover, and textDocument/rename will only work on the first line.

image
@rcjsuen rcjsuen added the bug label Nov 13, 2017
@rcjsuen rcjsuen self-assigned this Nov 14, 2017
rcjsuen added a commit that referenced this issue Nov 14, 2017
@rcjsuen
Add additional tests for #193
c88fdd5 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Nov 15, 2017
@rcjsuen
Fix #193 Support variables that span multiple lines
19e812a 
Fix the processing of variables that span multiple lines in LABEL
instructions as its properties are parsed differently from regular
instructions.

Signed-off-by: Remy Suen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen