Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --config with Config File #14

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Support --config with Config File #14

merged 3 commits into from
Oct 6, 2021

Conversation

TueeNguyen
Copy link
Contributor

Fixes #13

Adding a block of conditional code. Checking if config path is provided, then reading the options from the file.

If option -c or --config exists, other options are ignored!

@RC-Lee
Copy link
Owner

RC-Lee commented Oct 6, 2021

Hi, thanks for the PR.
I'd like it if you could be consistent with console errors and process exits.

  • On line 38, please use console.error for errors.
  • After line 42, please exit the processes gracefully after errors.

@RC-Lee RC-Lee merged commit e1d73bf into RC-Lee:main Oct 6, 2021
@RC-Lee RC-Lee mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New SSG feature: adding option --config with Config File
2 participants
@TueeNguyen @RC-Lee