Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logic to return error on failing to listen the events #65

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

kevinshahfws
Copy link
Contributor

No description provided.

@cletustboone
Copy link
Contributor

How was this tested? Is there a unit test that can be added to verify this behavior?

@kevinshahfws kevinshahfws changed the base branch from main to next November 3, 2022 14:15
@cletustboone cletustboone merged commit 846709e into rdkcentral:next Nov 4, 2022
cletustboone pushed a commit that referenced this pull request Nov 4, 2022
# [1.7.0-next.4](v1.7.0-next.3...v1.7.0-next.4) (2022-11-04)

### Bug Fixes

* Updated logic to return error on failing to listen the events ([#65](#65)) ([846709e](846709e))
@cletustboone
Copy link
Contributor

🎉 This PR is included in version 1.7.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

jlacivita added a commit that referenced this pull request Nov 4, 2022
HaseenaSainul pushed a commit to HaseenaSainul/firebolt-openrpc that referenced this pull request Jan 17, 2023
…dkcentral#65)

* Updated logic to return error on failing to listen the events

* Updated logic to return error on failing to listen the events

* Reverted format
HaseenaSainul pushed a commit to HaseenaSainul/firebolt-openrpc that referenced this pull request Jan 17, 2023
# [1.7.0-next.4](rdkcentral/firebolt-openrpc@v1.7.0-next.3...v1.7.0-next.4) (2022-11-04)

### Bug Fixes

* Updated logic to return error on failing to listen the events ([rdkcentral#65](rdkcentral#65)) ([846709e](rdkcentral@846709e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants