Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer events get passed to previous (invisible) month #224

Closed
Gnito opened this issue Dec 19, 2016 · 2 comments
Closed

Pointer events get passed to previous (invisible) month #224

Gnito opened this issue Dec 19, 2016 · 2 comments
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D

Comments

@Gnito
Copy link
Contributor

Gnito commented Dec 19, 2016

Pointer events should be disabled when using enableOutsideDays (tested with single month DayPicker).
This is a problem if previous month has more week rows than current month.

This could be fixed with simply adding pointer-events: none;

CalendarMonth.scss:

.CalendarMonth {
  text-align: center;
  padding: 0 13px;
  vertical-align: top;

  &:first-of-type {
    position: absolute;
    z-index: -1;
    opacity: 0;
    pointer-events: none;
  }
@majapw
Copy link
Collaborator

majapw commented Dec 20, 2016

This seems reasonable to me. Also I just reproed and agree, it's weird and we should probably fix that.

One thing is that maybe we should set pointer-events back to auto for .CalendarMonth--animating so that one can still interact with the calendar during the transition. Other than that I support this change.

@majapw majapw added bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D labels Dec 20, 2016
@majapw
Copy link
Collaborator

majapw commented Dec 20, 2016

Should be fixed in v4.3.0! Thanks!

@majapw majapw closed this as completed Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests

2 participants