Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Prep Cleanup #2478

Merged
merged 15 commits into from
May 23, 2020
Merged

Release Prep Cleanup #2478

merged 15 commits into from
May 23, 2020

Conversation

darthtrevino
Copy link
Member

  • Improve Typings
  • Eliminate default exports
  • Correct build warnings

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #2478 into master will increase coverage by 0.04%.
The diff coverage is 62.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
+ Coverage   52.29%   52.33%   +0.04%     
==========================================
  Files          87       87              
  Lines        2528     2543      +15     
  Branches      476      492      +16     
==========================================
+ Hits         1322     1331       +9     
- Misses       1206     1212       +6     
Impacted Files Coverage Δ
...core/src/actions/dragDrop/local/setClientOffset.ts 100.00% <ø> (ø)
packages/core/dnd-core/src/factories.ts 0.00% <0.00%> (ø)
packages/core/dnd-core/src/interfaces.ts 100.00% <ø> (ø)
...-backend/src/NativeDragSources/NativeDragSource.ts 4.16% <0.00%> (ø)
...backend/src/NativeDragSources/nativeTypesConfig.ts 42.85% <0.00%> (ø)
packages/core/react-dnd/src/common/DndContext.ts 100.00% <ø> (ø)
...core/react-dnd/src/common/DragSourceMonitorImpl.ts 6.55% <0.00%> (ø)
...core/react-dnd/src/common/DropTargetMonitorImpl.ts 7.14% <0.00%> (ø)
packages/core/touch-backend/src/interfaces.ts 100.00% <ø> (ø)
...kages/core/react-dnd/src/decorators/disposables.ts 17.80% <10.00%> (ø)
... and 52 more

@darthtrevino darthtrevino merged commit 4e57a34 into master May 23, 2020
@darthtrevino darthtrevino deleted the task/prep_release branch May 23, 2020 09:48
darthtrevino added a commit that referenced this pull request Feb 3, 2022
* feat: improve typings in touchbackend

* build: remove default exports from dnd-core react-dnd

* feat: remove default exports from backends

* refactor: reduce default exports in decorator examples

* fix: correct import

* refactor: remove default exports from hooks examples

* refactor: use component memoization in docsite

* docs: get docs up

* fix: linting corrections

* build: re-enable lint rule regarding non-null assertions

* build: prune eslint rule disables

* refactor: update backend named exports to not have 'factory' in name

* fix: ts issues

* fix: ts, test issues

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant