Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapInTestContext type signature #2637

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Conversation

traverse
Copy link
Contributor

Closes #2635

This fixes the type error you get when using wrapInTestContext on class components with getDerivedStateFromProps. It is possible that this change would break builds since the type is more specific compared to what it was before.

@traverse traverse requested a review from darthtrevino as a code owner June 26, 2020 14:31
@traverse traverse changed the title Fix wrapInTestContext type signature fixes Fix wrapInTestContext type signature Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #2637 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2637   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files          87       87           
  Lines        2544     2544           
  Branches      472      472           
=======================================
  Hits         1335     1335           
  Misses       1209     1209           

Copy link
Member

@darthtrevino darthtrevino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type signature for wrapInTestContext doesn't work on class components with getDerivedStateFromProps
2 participants