You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But to clarify, if you make a plugin that has a --version flag, this flag is now (not sure which commit/PR changed this) passed as a function
Reproducible Demo
Make a plugin with this, the version should be logging function instead of string:
module.exports={commands: [{name: 'foo',func: (_,config,args)=>{// at least when --version is not specified, I'm receiving a function here.console.log(args.version)// Function instead of string},options: [{name: '--version [String]',description: 'Foo'},]}]}
If this is not really a problem, I at least expect to be warned in the docs about this..
The text was updated successfully, but these errors were encountered:
Does it happen when you name the arg to something different? --version is a special case for the commanderjs lib we're using for parsing arguments. And it gave us headaches as well.
Nop, I thought that it would be the case, so I've already changed the flag to semver.. so for me it's solved, but a warning in the docs would be welcome
I could open a PR for that of you wish so... But maybe there are other reserved words that I don't know that could be documented 🤔
Environment
Description
The issue maybe explained better here:
Grohden/react-native-cli-bump-version#4
But to clarify, if you make a plugin that has a --version flag, this flag is now (not sure which commit/PR changed this) passed as a function
Reproducible Demo
Make a plugin with this, the version should be logging function instead of string:
If this is not really a problem, I at least expect to be warned in the docs about this..
The text was updated successfully, but these errors were encountered: