Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about modules requiring main queue setup #140

Closed
benjarwar opened this issue Jun 14, 2018 · 14 comments
Closed

Warnings about modules requiring main queue setup #140

benjarwar opened this issue Jun 14, 2018 · 14 comments
Labels

Comments

@benjarwar
Copy link

Describe the bug
After recently upgrading to React Native 0.55.4, I've started seeing similar YellowBox warnings for three modules:

Module Gyroscope requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup.

Module Accelerometer requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup.

Module Magnetometer requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup.

To Reproduce
Steps to reproduce the behavior:

  1. I'm only using the Accelerometer in my project
  2. import { Accelerometer } from "react-native-sensors";
  3. See error in Simulator on app start

Expected behavior
Not expecting warnings.

Desktop (please complete the following information):

  • React Native Version: 0.55.4
  • Device: iOS Simulator
  • Version: 3.0.0

Additional context
Here's the same issue fixed for a React Native component.

@DanielMSchmidt
Copy link
Member

Thank you for this detailed bug report, kudos for taking the time!

It seems like you have pretty much sorted out what needs to be done, would you feel okay with doing also the PR? Would love to guide you through the process if you like

@benjarwar
Copy link
Author

@DanielMSchmidt would like to, but probably won't have time in the short term.

@maxkomarychev
Copy link
Contributor

maxkomarychev commented Jun 15, 2018

@benjarwar this is supposed to be fixed by #134
which version of react-native-sensors are you using? I see you're using 3.0.0 :)

@maxkomarychev
Copy link
Contributor

@DanielMSchmidt it worth publishing new version with recent fixes

@DanielMSchmidt
Copy link
Member

@maxkomarychev Somehow my npm publish didn't work 😢 Could you tell me your npm username so I can add you there?

@stale
Copy link

stale bot commented Jul 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 15, 2018
@stale stale bot closed this as completed Jul 22, 2018
@DanielMSchmidt
Copy link
Member

@maxkomarychev pinging again :)

@tetreault
Copy link

After sorting out my own mistakes with this module I got it working but also receive the yellow box warnings. Not sure how to fix it -- any advice @maxkomarychev @DanielMSchmidt ?

i'm using "react-native-sensors": "^3.0.0" but still have this problem when running my prototype on my iphone X

@cyb3rsalih
Copy link

I only add the react-native-sensors package not even import it. But still see the warnings both for
Magnetometer , Accelerometer , Gyroscope

@jan-happy
Copy link
Contributor

+1

@DanielMSchmidt
Copy link
Member

I am terribly sorry, but I haven't had the time to look into any issues in this project lately. I will try my best to free up some time to go through the issues soon, but if you need a fix soon feel free to open up a PR, I am more than happy to review!

@jan-happy
Copy link
Contributor

jan-happy commented Sep 13, 2018

@DanielMSchmidt: It's supposed to be fixed here:#134
But that change is not present in 3.0.0

@DanielMSchmidt
Copy link
Member

I now published 3.1.0

@jan-happy
Copy link
Contributor

@DanielMSchmidt Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants