Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Image.propTypes with ImagePropTypes. #2718

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Replace Image.propTypes with ImagePropTypes. #2718

merged 1 commit into from
Jun 15, 2022

Conversation

devon-whil
Copy link
Contributor

Fixes: #2714

@devon-whil
Copy link
Contributor Author

devon-whil commented Jun 14, 2022 •
edited
Loading

I am also getting the following error with [email protected]:

▸ Compiling RCTVideoManager.swift

❌  /Users/devon/projects/frontend/node_modules/react-native-video/ios/Video/RCTVideoManager.swift:8:49: cannot convert value of type 'RCTEventDispatcherProtocol?' to expected argument type 'RCTEventDispatcher?'

This error goes away when I change the type as it suggested. Seems this change would break support for older versions of react-native. @freeboub Should that change be part of this PR?

freeboub
freeboub approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@freeboub freeboub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on sample, looks good

@freeboub
Copy link
Collaborator

I am also getting the following error with [email protected]:

▸ Compiling RCTVideoManager.swift

❌  /Users/devon/projects/frontend/node_modules/react-native-video/ios/Video/RCTVideoManager.swift:8:49: cannot convert value of type 'RCTEventDispatcherProtocol?' to expected argument type 'RCTEventDispatcher?'

This error goes away when I change the type as it suggested. Seems this change would break support for older versions of react-native. @freeboub Should that change be part of this PR?

Thank @devon-whil, I think it is better to keep separate change in small Prs, it is really easier to review !

@hueniverse hueniverse added this to the 6.0.0-alpha.1 milestone Jun 15, 2022
@hueniverse hueniverse merged commit 7236bbb into TheWidlarzGroup:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
dependency Platform: iOS
Projects
None yet
Milestone
6.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

ERROR TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.resizeMode')
4 participants
@devon-whil @freeboub @hueniverse @armands-malejevs