Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product variant must have a option to inherit picture from parent #1322

Closed
3Maestros opened this issue Aug 23, 2016 · 4 comments · Fixed by #1693
Closed

Product variant must have a option to inherit picture from parent #1322

3Maestros opened this issue Aug 23, 2016 · 4 comments · Fixed by #1693
Assignees
Milestone

Comments

@3Maestros
Copy link

3Maestros commented Aug 23, 2016

For bugs, please fill out the three following sections completely

Expected behavior

Product variant must have a option to inherit picture from parent

Actual Behavior

Steps to Reproduce the Behavior

For enhancements or other issues, please describe in as much detail as
possible how the app should be changed and how this would benefit
users/developers

@aaronjudd
Copy link
Contributor

aaronjudd commented Aug 25, 2016

@3Maestros I can confirm that this is the expected behaviour, but only in USER view, if you are logged in as an admin it will not inherit from parent.. so that you are able to identify which product variants do have images..

@3Maestros
Copy link
Author

@aaronjudd yes for admin,by default it may be inheriting from parent but there should be simple "check box" that says inherit image from parent.

@aaronjudd aaronjudd added the ready label Dec 5, 2016
@aaronjudd aaronjudd added this to the v0.19.0 milestone Dec 5, 2016
@mikemurray mikemurray changed the title Product variant must have a option to inherit picture from parent Product variant must have a option to inherit picture from parent Dec 21, 2016
@mikemurray
Copy link
Member

Child variants in the published product are not inheriting the parent images if non is set.

@kieckhafer
Copy link
Member

Fixed by #1664.

@ghost ghost removed the review label Dec 22, 2016
@aaronjudd aaronjudd mentioned this issue Jan 6, 2017
@ghost ghost assigned aaronjudd Jan 6, 2017
@ghost ghost added the review label Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants