Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to cart alert behaviour #1445

Closed
aaronjudd opened this issue Sep 27, 2016 · 8 comments
Closed

Add to cart alert behaviour #1445

aaronjudd opened this issue Sep 27, 2016 · 8 comments
Assignees
Milestone

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 27, 2016

Expected behavior

When I rapidly add multiple items to cart, I expect there to be some recurring updates in the "Add to Cart" slideout.

Actual Behavior

Formerly this was implemented using jQuery easing, which provided some queueing, and would display additional updates when additional items were added to the cart. Now using just CSS, we aren't getting additional updates

Steps to Reproduce the Behavior

Add item to cart, see slider. Add to cart again (and again, and again) and slide out will not appear

@aaronjudd aaronjudd added the UIX label Sep 27, 2016
@aaronjudd aaronjudd added this to the v0.19.0 milestone Sep 27, 2016
@aaronjudd aaronjudd modified the milestones: v0.19.0, v0.20.0 Feb 7, 2017
@kieckhafer kieckhafer modified the milestones: Next, v0.20.0 Feb 15, 2017
@abdulsemiu-atanda abdulsemiu-atanda self-assigned this Mar 22, 2017
@abdulsemiu-atanda
Copy link
Contributor

I'll reproduce this behavior and work on solving it over the next couple of days.

@abdulsemiu-atanda
Copy link
Contributor

@aaronjudd reducing the slide out delay time from 4s to 0.4s somehow fixes this. Is there any reason why it was kept at 4s?

@brent-hoover
Copy link
Collaborator

The slideout delay is 4s so that the toast remains on the screen long enough for you to read it. You could probably reduce it some, but making it .4s is way too fast.

@aaronjudd
Copy link
Contributor Author

@andela-aatanda agree with Brent, the goal here is a smooth visual effect that is noticeable and gives time for a user to see the action, this issue is not about the behaviour of adding one item, but the effect that occurs while you add more than one item and it's already slide out once.

@abdulsemiu-atanda
Copy link
Contributor

Gotcha.

@abdulsemiu-atanda
Copy link
Contributor

@zenweasel I was thinking if the Add To Cart button is deactivated pending the time the cart-alert goes back in this behavior will be prevented. Will deactivating the Add To Cart button be a behavior we'll want to have?

@rymorgan
Copy link
Contributor

rymorgan commented Mar 30, 2017

@zenweasel and I were talking this through and here's what we came up with.
When you click quickly to add to cart multiple times, it should update the original alert and restart the animation. It should count up and if it was starting to slide out it would start the time over again. So it’s always 4 seconds from the last time you clicked the add to cart button.

When it updates the alert, display a spinner. (you can use the same spinner we use on buttons like the complete payment button). Text should quick fade down, display spinner, and fade back up.

See rough mockup.

cart - toast

@abdulsemiu-atanda
Copy link
Contributor

@rymorgan This put things in better perspective. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants