Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDP] Revision images #1456

Closed
aaronjudd opened this issue Sep 30, 2016 · 1 comment · Fixed by #1693
Closed

[PDP] Revision images #1456

aaronjudd opened this issue Sep 30, 2016 · 1 comment · Fixed by #1693
Assignees
@mikemurray @brent-hoover @aaronjudd
Milestone
v0.18.0

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 30, 2016 •
edited
Loading

Task from #1356

Currently in the PDP revisions do not control images. If you delete (or update) an image but haven't published the image, it's deleted in the published product as well (and it should not).

We can use the CFS metadata to store revision / publish state for the images.
@aaronjudd aaronjudd added this to the v0.17.0 milestone Sep 30, 2016
@aaronjudd aaronjudd modified the milestones: v0.17.0, v0.18.0 Oct 19, 2016
@brent-hoover brent-hoover mentioned this issue Oct 21, 2016
Merged
@brent-hoover brent-hoover mentioned this issue Nov 7, 2016
Merged
@brent-hoover
Copy link
Collaborator

Closed by PR #1555

@ghost ghost removed the review label Nov 18, 2016
@aaronjudd aaronjudd mentioned this issue Jan 6, 2017
Merged
@ghost ghost assigned aaronjudd Jan 6, 2017
@ghost ghost added the review label Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemurray mikemurray

@brent-hoover brent-hoover

@aaronjudd aaronjudd

Labels
None yet
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

Release 18 reactioncommerce/reaction
3 participants
@mikemurray @brent-hoover @aaronjudd