Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDP UX for Shipping, Taxes #1699

Closed
aaronjudd opened this issue Jan 9, 2017 · 10 comments
Closed

PDP UX for Shipping, Taxes #1699

aaronjudd opened this issue Jan 9, 2017 · 10 comments
Assignees
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Milestone

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Jan 9, 2017

For implementation of #1618, we need UX for designed for the following information on product details page:

Dimensions [Width (x) Length, Depth]
Customs Category (select from list)
Tax Code Category (select from list)

@rymorgan this is likely some additional fields, in the same area vein as the existing inventory, pricing.

@aaronjudd aaronjudd added this to the v0.20.0 milestone Jan 9, 2017
@aaronjudd
Copy link
Contributor Author

@lcampanis your feedback on additional fields for customs here would be great.

@prosf
Copy link
Collaborator

prosf commented Jan 10, 2017

Hi aaronjudd

The Shippo fields required for any type of label (Shipping & Customs) to be generated are:

  • weight
  • mass_unit (kg, oz, ...) (Available from Shop's BaseUOM)
  • length
  • width
  • height
  • distance_unit (cm, in, ...) (Need Shop's BaseUOM for distance)

Height, length, width and weight of parcel (shippingParcel schema) are the ones needed in the UI.

For international orders requiring a customs declaration, the minimum required fields are :

origin_country and description of item are also needed in the UI.

These are just the required ones,in my opinion. More fields are available here:
https://goshippo.com/docs/reference#customs-items-create
https://goshippo.com/docs/reference#customs-declarations

@aaronjudd
Copy link
Contributor Author

@prosf great, thanks. we're discussing the best way to present these in the product detail page, and should begin implementing this week (along with some additional stuff for taxes,etc)

@brent-hoover
Copy link
Collaborator

I think we should probably add a "Tax Description" field that's optional but when filled in is passed along to the tax provider rather than the stock title/description.

@aaronjudd
Copy link
Contributor Author

See the parcel object for shipping: https://goshippo.com/docs/reference#parcels

We'll need all that dimensional data.

@rymorgan
Copy link
Contributor

rymorgan commented Feb 17, 2017

Here's a mock w/ measurements added. And a dropdown for tax codes. For the measurements I added a selector to change your unit of measurement. Check out: #1647 for some more detailed notes related to this and the overall PDP UI.

sidebar - pdp reorg - edit variant
sidebar - pdp reorg - w unit selector

@brent-hoover
Copy link
Collaborator

Disregard references to Customs on this ticket. This has now been moved to #1862. Should just be dimensions plus Tax Code.

@brent-hoover brent-hoover changed the title PDP UX for Shipping, Taxes, Customs PDP UX for Shipping, Taxes Feb 21, 2017
@kieha
Copy link
Contributor

kieha commented Feb 24, 2017

@rymorgan this is what the PDP will look like once I'm done with this ticket
screen shot 2017-02-24 at 12 59 11 pm

@rymorgan
Copy link
Contributor

rymorgan commented Feb 27, 2017

@kieha This meets the requirement for adding the fields. The UI refactor and cleanup has been broken into another ticket. See issue below.
#1647

@kieha
Copy link
Contributor

kieha commented Feb 28, 2017

@rymorgan noted.

@ghost ghost added review and removed in progress labels Mar 2, 2017
@kieckhafer kieckhafer added the epic For issues that exist only to track progress on a list of other issues in one place label Mar 6, 2017
@kieckhafer kieckhafer removed the review label Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Projects
None yet
Development

No branches or pull requests

6 participants