Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addBodyClass on notFound page #1734

Closed
lcampanis opened this issue Jan 19, 2017 · 1 comment
Closed

Fix addBodyClass on notFound page #1734

lcampanis opened this issue Jan 19, 2017 · 1 comment
Assignees

Comments

@lcampanis
Copy link
Collaborator

Since the "not found" page isn't a registered route, there is no way of getting the routeName or theme for that route and the function breaks when the Not Found page is loaded.

addBodyClass should add an app-not-found class to the body when loading that view.

Note: There is still no clear way of how to get the current route theme though, since there is no route declared for not found. There should be a declared notFound route with a theme assigned or a global DEFAULT_THEME (food for thought)

@mikemurray
Copy link
Member

Merged changes into 0.19.0

@ghost ghost assigned mikemurray Jan 26, 2017
@ghost ghost removed the in progress label Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants