Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting broken on completed page when using non-USD #1960

Closed
brent-hoover opened this issue Mar 11, 2017 · 5 comments
Closed

Formatting broken on completed page when using non-USD #1960

brent-hoover opened this issue Mar 11, 2017 · 5 comments
Assignees
@aaronjudd @abdulsemiu-atanda
Labels
verified reproducible For issues that describe bugs that the core team was able to confirm
Milestone
Next

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Mar 11, 2017 •
edited by abdulsemiu-atanda
Loading

Expected behavior

All currencies should be formatted correctly

Actual Behavior

Subtotals wrap strangely
cart_completed

Steps to Reproduce the Behavior

  1. reaction reset -n
  2. Change currency via dropdown to PHP (probably works with Euros as well)
  3. Place an order
  4. Observe formatting on completed page

It doesn't seem to be related to # of digits as I did an order for $133,000.00 and it still formatted correctly.
@aaronjudd aaronjudd added UIX verified reproducible For issues that describe bugs that the core team was able to confirm labels Mar 14, 2017
@aaronjudd aaronjudd added this to the Next milestone Mar 14, 2017
@abdulsemiu-atanda abdulsemiu-atanda self-assigned this Mar 27, 2017
@abdulsemiu-atanda
Copy link
Contributor

I'll reproduce this behavior and work on solving it over the next couple of days

@abdulsemiu-atanda
Copy link
Contributor

@zenweasel I can't seem to find PHP in the currency dropdown. Has PHP been deprecated?

@brent-hoover
Copy link
Collaborator Author

It works with any non-USD currency but also

cart_completed

@abdulsemiu-atanda
Copy link
Contributor

Gotcha

@abdulsemiu-atanda abdulsemiu-atanda mentioned this issue Mar 30, 2017
Merged
@ghost ghost added review and removed in progress labels Mar 30, 2017
@brent-hoover
Copy link
Collaborator Author

Closed via #2062

@ghost ghost removed the review label Mar 31, 2017
@ghost ghost assigned aaronjudd Apr 3, 2017
@ghost ghost added the review label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronjudd aaronjudd

@abdulsemiu-atanda abdulsemiu-atanda

Labels
verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@brent-hoover @aaronjudd @abdulsemiu-atanda