Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve warning issues with Dropzone in console #1994

Closed
brent-hoover opened this issue Mar 15, 2017 · 2 comments
Closed

Resolve warning issues with Dropzone in console #1994

brent-hoover opened this issue Mar 15, 2017 · 2 comments
Assignees
@abdulsemiu-atanda

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Mar 15, 2017 •
edited by abdulsemiu-atanda
Loading

Expected behavior

No warnings or errors in console.

Actual Behavior

Receive these warnings in the console

Prop className is deprecated. Use function as children to style dropzone and its contents.
Prop maxSize is deprecated and will be removed in the next major release
Prop minSize is deprecated and will be removed in the next major release

Steps to Reproduce the Behavior

  1. Open dev console
  2. Open Reaction
  3. Login to as an admin
  4. Go to PDP
  5. Observe console warnings

Obviously note a high priority issue but hopefully we can resolve before it becomes one.
@aaronjudd aaronjudd added this to the v1.0.0 milestone Mar 16, 2017
@brent-hoover brent-hoover modified the milestones: Next, v1.0.x Mar 28, 2017
@aaronjudd aaronjudd added the UIX label Mar 28, 2017
@aaronjudd aaronjudd modified the milestones: Next, v1.0.x Mar 28, 2017
@aaronjudd aaronjudd added this to the Next milestone Mar 28, 2017
@brent-hoover
Copy link
Collaborator Author

Resolved in current development version

@ghost ghost removed the ready label Mar 28, 2017
@brent-hoover
Copy link
Collaborator Author

I closed this prematurely. When you go to the PDP as an admin you still see this warning.

@brent-hoover brent-hoover reopened this Mar 29, 2017
@brent-hoover brent-hoover removed their assignment Mar 30, 2017
@aaronjudd aaronjudd modified the milestones: v1.2.x, Next Apr 11, 2017
@abdulsemiu-atanda abdulsemiu-atanda self-assigned this Apr 13, 2017
@abdulsemiu-atanda abdulsemiu-atanda mentioned this issue Apr 18, 2017
Merged
@ghost ghost added review and removed in progress labels Apr 18, 2017
@aaronjudd aaronjudd mentioned this issue Apr 18, 2017
Merged
@aaronjudd aaronjudd mentioned this issue Jun 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdulsemiu-atanda abdulsemiu-atanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brent-hoover @aaronjudd @abdulsemiu-atanda