Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move/add variant icon buttons. #2031

Closed
rymorgan opened this issue Mar 22, 2017 · 4 comments
Closed

Move/add variant icon buttons. #2031

rymorgan opened this issue Mar 22, 2017 · 4 comments
Assignees
@kieckhafer

Comments

@rymorgan
Copy link
Contributor

rymorgan commented Mar 22, 2017 •
edited
Loading

  1. Move Public/Private icon button from body of the page to sidebar.
  2. When the variant is set to private, fade it out
  3. Change placement of icon buttons for variant options in sidebar
  4. Add ability to clone a variant option

pdp_-_action_view-2
pdp_-_action_view-1
@rymorgan rymorgan mentioned this issue Mar 22, 2017
Closed
@rymorgan rymorgan added the UIX label Mar 22, 2017
@rymorgan rymorgan added this to the v1.0.x milestone Mar 22, 2017
@rymorgan rymorgan changed the title Move/add variant icon buttons. Move/add variant icon buttons. Mar 22, 2017
@rymorgan rymorgan added the ready label Mar 22, 2017
@brent-hoover brent-hoover modified the milestones: Next, v1.0.x Mar 28, 2017
@joykare joykare assigned joykare and unassigned joykare Mar 28, 2017
@aaronjudd aaronjudd modified the milestones: Next, v1.0.x Mar 28, 2017
@hrath2015 hrath2015 mentioned this issue Mar 31, 2017
Merged
@kieha kieha mentioned this issue Apr 5, 2017
Closed
@aaronjudd aaronjudd modified the milestones: PDP UI Components, Next Apr 25, 2017
@rymorgan
Copy link
Contributor Author

@kieckhafer This is one of the issues that you are at least partially fixing.

@aaronjudd
Copy link
Contributor

Demo'ed this morning... so assigned to @kieckhafer

@kieckhafer
Copy link
Member

^^ Yes this is done in PR #2893

@kieckhafer
Copy link
Member

Closed by #2893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kieckhafer kieckhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brent-hoover @aaronjudd @kieckhafer @joykare @rymorgan