Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Marketplace and Shop owners should be able to create custom permission groups #2194

Closed
spencern opened this issue May 1, 2017 · 4 comments
Assignees

Comments

@spencern
Copy link
Contributor

spencern commented May 1, 2017

Marketplace and shop owners should be able to create additional permission groups with custom names and a custom set of permissions.

Owners should be able to define granular permissions for these groups.

Once created these permission groups should be available anywhere other default permission groups are available.

@spencern spencern added this to the Marketplace Permissions milestone May 1, 2017
@spencern spencern changed the title Marketplace and Shop owners should be able to create custom permission groups [Marketplace] Marketplace and Shop owners should be able to create custom permission groups May 1, 2017
@rymorgan
Copy link
Contributor

Links for designs below

Design annotations in Zeplin :)

Reaction core team link:
Web: https://zpl.io/1YphHq
Zeplin App: zpl://project?pid=59487558eca97e6140dd4b5b

Public link:
https://scene.zeplin.io/project/59487558eca97e6140dd4b5b

@rymorgan
Copy link
Contributor

rymorgan commented Jul 13, 2017

Here are the latest screens for Permissions. After looking through it with @kieckhafer made some small edits.

  1. A different way to change the default group.
  2. Changed one icon button from a cog to a pencil b/c it makes more sense.
  3. Added a way to delete groups.

Screens:
Intial User Screen- https://zpl.io/Z162xqi
Edit Permissions Screen - https://zpl.io/nVX8n
Edit Groups - https://zpl.io/Zh8Rdn
Add Group - https://zpl.io/ZTEMLM
Edit Owner - https://zpl.io/15nVaK

@impactmass
Copy link
Contributor

impactmass commented Jul 14, 2017

Thanks @rymorgan. I'll take a look at the designs. If there be questions, I'll ask you/Erik.

Just a note: I'm using this other ticket #2184 to post updates of the state of the implementation.... there are a number of tickets related to this mockup, but I'm just posting in one ticket ( #2184)

@impactmass
Copy link
Contributor

A functional (base) UI of the groups view (creating and editing groups, switching user from one group to another, and adding users to groups) was merged in with this PR #2543.
Now, admins can create permission groups from the UI (using the already merged in methods #2448) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants