Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Image icon does nothing #2242

Closed
spencern opened this issue May 11, 2017 · 7 comments
Closed

Edit Image icon does nothing #2242

spencern opened this issue May 11, 2017 · 7 comments
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@spencern
Copy link
Contributor

spencern commented May 11, 2017

image

Expected behavior

Something should happen when I click the button

Actual Behavior

Nothing happens.

Steps to Reproduce the Behavior

  1. Clone dev
  2. Login.
  3. Add and image.
  4. Click the "edit image" button in either the main image or the sub image section.

Versions

Node: 7.8.0
NPM: 4.5.0
Meteor Node: 4.8.2
Meteor NPM: 4.5.0
Reaction CLI: 0.8.1
Reaction: 1.1.1
Reaction branch: brent-revert-permissions-fix
Docker: 17.03.1-ce

This button disappears after publishing the image

@brent-hoover
Copy link
Collaborator

@spencern Is this a product image or a store image? Or both?

@aaronjudd
Copy link
Contributor

aaronjudd commented May 11, 2017

@rymorgan I don't know if the design changed, but I noticed this as well. those don't look very aligned, and look sorta broken generally to me... are they correct?

@spencern
Copy link
Contributor Author

@zenweasel I've noticed this only on product images. Can't say for sure that it's not happening on store images though.

@spencern spencern added bug For issues that describe a defect or regression in the released software UIX labels Jun 5, 2017
@kieckhafer
Copy link
Member

This isn't the case of a non-working button, this is the case of a bad icon / button / indicator for what it's purpose is supposed to be.

That icon is just an indication that the image has changed, and isn't yet published. That means it's either a newly added image, or a deleted image, and when the product is published, the changes will be made. That's why it goes away when you publish.

@rymorgan perhaps we should change this to be the same as the products on the grid, with the little blue indicator on the top right?

reaction

@brent-hoover
Copy link
Collaborator

@kieckhafer I feel like this is 100% what should happen and pretty sure we had discussed this before and agreed that's what we should do.

@rnandhakumar1995
Copy link

In file imports/plugins/core/ui/client/components/media/mediaGallery.js enable the state "disableClick" of Dropzone component at line 131

@kieckhafer
Copy link
Member

Closed by #2469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

5 participants