-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Image icon does nothing #2242
Comments
@spencern Is this a product image or a store image? Or both? |
@rymorgan I don't know if the design changed, but I noticed this as well. those don't look very aligned, and look sorta broken generally to me... are they correct? |
@zenweasel I've noticed this only on product images. Can't say for sure that it's not happening on store images though. |
This isn't the case of a non-working button, this is the case of a bad icon / button / indicator for what it's purpose is supposed to be. That icon is just an indication that the image has changed, and isn't yet published. That means it's either a newly added image, or a deleted image, and when the product is published, the changes will be made. That's why it goes away when you publish. @rymorgan perhaps we should change this to be the same as the products on the grid, with the little blue indicator on the top right? |
@kieckhafer I feel like this is 100% what should happen and pretty sure we had discussed this before and agreed that's what we should do. |
In file imports/plugins/core/ui/client/components/media/mediaGallery.js enable the state "disableClick" of Dropzone component at line 131 |
Closed by #2469 |
Expected behavior
Something should happen when I click the button
Actual Behavior
Nothing happens.
Steps to Reproduce the Behavior
Versions
This button disappears after publishing the image
The text was updated successfully, but these errors were encountered: