Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes the first variant is not automatically selected on page load. A placeholder is shown. #3208

Closed
arsen3d opened this issue Oct 30, 2017 · 9 comments
Closed

Sometimes the first variant is not automatically selected on page load. A placeholder is shown. #3208

arsen3d opened this issue Oct 30, 2017 · 9 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@arsen3d
Copy link

arsen3d commented Oct 30, 2017

Node: 8.6.0
NPM: 5.3.0
Meteor Node: 4.8.4
Meteor NPM: 4.6.1
Reaction CLI: 0.19.1
Reaction: 1.5.4
Reaction branch: master
Docker: 17.09.0-ce
@brent-hoover
Copy link
Collaborator

@arsen3d Can you fill out the issue template so we some way of reproducing this bug?

Expected behavior

Actual behavior

Steps to reproduce the behavior

@arsen3d
Copy link
Author

arsen3d commented Nov 1, 2017 •
edited by brent-hoover
Loading

Expected Behavior

-For image of first variant to be shown

Actual behavior

-The top variant is not selected

Steps to reproduce the behavior

-Loading the page
screenshot 2017-10-31 22 11 21

@brent-hoover brent-hoover added the bug For issues that describe a defect or regression in the released software label Nov 14, 2017
@brent-hoover
Copy link
Collaborator

I believe related to #3263

@arsen3d arsen3d closed this as completed Nov 17, 2017
@arsen3d arsen3d mentioned this issue Nov 17, 2017
Closed
@arsen3d
Copy link
Author

arsen3d commented Nov 17, 2017

Solved in #3305

@brent-hoover brent-hoover reopened this Nov 17, 2017
@arsen3d
Copy link
Author

arsen3d commented Nov 17, 2017

What is the process flagging issue as resolved, after I submit a pull request? Do you guys have a process flow document on this topic?

@brent-hoover
Copy link
Collaborator

If your PR says "Resolves #XXX" or "Closes #XXX" the issue will be automatically closed when the PR is merged.

We don't have good docs to point to as far as the process though we are in the process of creating those. Generally @spencern or I will handle closing tickets when we prepare a release.

@brent-hoover
Copy link
Collaborator

docs updated: https://docs.reactioncommerce.com/reaction-docs/master/code-reviews

@brent-hoover
Copy link
Collaborator

I believe this was fixed via #3267 but we need to verify fixed.

@brent-hoover
Copy link
Collaborator

Confirmed this is fixed in master. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brent-hoover @arsen3d