Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing display of priceRange in product Detail page. #3303

Closed
ushadev opened this issue Nov 16, 2017 · 8 comments
Closed

Missing display of priceRange in product Detail page. #3303

ushadev opened this issue Nov 16, 2017 · 8 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@ushadev
Copy link

ushadev commented Nov 16, 2017

Expected behavior

When we click on the products and route to the specific product detail page of the product we should see the priceRange of the product displayed. no matter how many times we select different products and go to the product detail page.

Actual behavior

suppose 3 products are added to Shop tag. we logout of the admin. we navigate to the Shop Tag and click on any product. it leads to the product detail page of that specific product. the props(priceRange) is passed and we can see the priceRange in the product detail page. now then on if we select any other product from the Shop tag and go to the product detail page the props (priceRange) is not passed and the priceRange is not displayed. Only when we refresh the page the props (priceRange) is getting passed and then we can see the priceRange.

Steps to reproduce the behavior

1.) Create 3 products under Shop tag.
2.) Signout.
3.) Go to Shop Tag. click on any product. it leads to the product Detail page of the respective product. here you can see the priceRange displayed.
4.) Go back to the Shop Tag and select a different Product. it leads to the product Detail page . here you can't see the priceRange value of the product. (this is the bug the props are not getting passed for the priceRange) but if you refresh the page (the props get passed and) the priceRange value is displayed.

Versions

reaction 1.5 and above

@brent-hoover
Copy link
Collaborator

I think this issue is related to: #3227 where the variant is not selected so the image/price is not shown unless you select a variant

@ushadev
Copy link
Author

ushadev commented Nov 17, 2017

In the case i am referring to, i dont have any variants for my products, then it would be just the Top level variant for all my products. so i need not select the variant.

@ushadev
Copy link
Author

ushadev commented Nov 17, 2017

yes you are right the issue i raised is related to :#3227. Got the fix pulled and tested and it worked. Thankyou.

@brent-hoover brent-hoover added the bug For issues that describe a defect or regression in the released software label Nov 20, 2017
@codejockie
Copy link
Contributor

@zenweasel can this issue be closed since issue #3227 which is related to this one has been fixed with #3267?

@brent-hoover
Copy link
Collaborator

@codejockie Have you verified that it's fixed?

@codejockie
Copy link
Contributor

@zenweasel No I haven't but can verify it.

@codejockie
Copy link
Contributor

@zenweasel verified, fixed.

@brent-hoover
Copy link
Collaborator

Resolved via #3267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

3 participants